Skip to content

feat(desktop): over-threshold resume guard and compaction_done live refresh - #8256

Open
complyue wants to merge 1 commit into
esengine:main-v2from
complyue:feature/compaction-thresholds-slider
Open

feat(desktop): over-threshold resume guard and compaction_done live refresh#8256
complyue wants to merge 1 commit into
esengine:main-v2from
complyue:feature/compaction-thresholds-slider

Conversation

@complyue

@complyue complyue commented Aug 10, 2026

Copy link
Copy Markdown

What

Turns the single compact_ratio knob into four explicit, independently
configurable compaction thresholds (soft / snip / compact / force), exposes
real context occupancy end-to-end, and renders all four as live pins on the
desktop context gauge with a draggable settings slider.

  • Agent: compactThresholds() now computes soft/snip/compact/force
    boundaries from the four ratios; the existing prune-then-summarize tiered
    pipeline keys off the real context shape (ContextPromptTokens) with
    billable-token fallback. Config re-validation keeps the chain
    soft < snip < compact < force legal on every change.
  • Config: reasonix config compact-ratio [--local] [VALUE] accepts
    10–95%; new snip-ratio command accepts 5–95%. Project-local values
    override the shared user config used by desktop and new CLI sessions.
  • Control: SessionHistory.CompactThresholds() and
    ContextInfo's soft/snip/force ratios feed the desktop gauge; the
    settings view exposes the slider.
  • Desktop: settings slider with soft/snip/compact/force pins, real
    occupancy ring (ContextReport + maintenance), context capacity pins in
    the overview, and per-threshold copy in zh/zh-TW.

Docs: docs/SPEC.md context-maintenance section rewritten for the tiered
thresholds (removed the "65–85%" single-threshold description).

Commit 2 is the ratchet/budget bookkeeping only (repolint baseline growth +
bundle budgets for the added code and locale copy), kept separate from the
feature diff for review.

Verification

  • go build ./internal/... and go build ./... (desktop) pass
  • go vet clean on internal/agent, internal/control, internal/config
  • go test ./internal/agent/ ./internal/control/ ./internal/config/ pass
  • pnpm exec tsc --noEmit clean
  • node scripts/check-bundle-budget.mjs all PASS
  • go run ./tools/repolint clean (1958 baselined findings)

Cache-impact: none - compact* changes are threshold getters/computation only; the provider-visible prefix stays byte-identical
Cache-guard: no prefix-assembly path changed; run go test ./internal/boot/ (prefix stability effect tests) plus the agent/control/config suites above
System-prompt-review: complyue (author) - internal/config threshold keys feed the config surface but do not alter the byte-stable system-prompt prefix
Documentation-impact: updated - docs/SPEC.md context-maintenance section rewritten for the four tiered thresholds

@github-actions github-actions Bot added desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) v2 Go rewrite (1.x) — main-v2 branch, active development labels Aug 10, 2026
@complyue

complyue commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Here's updated UI:

Note it's now log-scale for the x-axis, so lower ranges occupy more horizontal space.

Settings:
image

Right Panel:
image

image

@SivanCola

SivanCola commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thank you. I will start the review once you are ready.

@SivanCola

SivanCola commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the thoughtful UI work and focused tests. I reviewed this branch against the latest main-v2, and there is an important architectural conflict to resolve before rebasing.

#8244 has now landed and intentionally replaced the former multi-threshold maintenance path with one cache-first compact_ratio trigger. On current main-v2:

  • soft_compact_ratio, tool_result_snip_ratio, and compact_force_ratio are compatibility fields that are cleared during config loading;
  • automatic snip/prune projections are no-ops;
  • only compact_ratio (default 85%) drives automatic context maintenance.

This also exposes a semantic mismatch in the current four-thumb UI: in this branch, Snip is not an independent trigger at 60%. Tool-result cleanup starts only when Compact is reached (80% by default), and Snip is the target the cleanup result must fall below to avoid summary compaction. Presenting it as a separate cleanup trigger would therefore be misleading.

A mechanical rebase would either leave three slider thumbs disconnected from runtime behavior or require reverting #8244's cache-first contract, which could cause earlier prompt rewrites and lower prompt-cache reuse. #8265 has also removed the ContextPanel short-view block, so that block should not be reintroduced during conflict resolution.

The parts that still fit the current architecture are valuable:

  • live capacity visualization aligned with the actual single Compact threshold;
  • a single-threshold settings control;
  • the over-threshold resume guard, after moving confirmation before the mutating ResumeSessionPageForTab / OpenChannelSessionPageForTab calls;
  • immediate context and balance refresh after compaction_done.

Could you please re-scope this PR around the current single-threshold architecture and preserve #8265's ContextPanel deletion? If four independently configurable thresholds are still desired, that should be a separate product/architecture proposal because it changes the behavior and cache guarantees established by #8244.

@complyue
complyue force-pushed the feature/compaction-thresholds-slider branch from a3f5cc9 to 3b3ddfb Compare August 11, 2026 11:26
complyue pushed a commit to complyue/DeepSeek-Reasonix that referenced this pull request Aug 11, 2026
cyue
feat(desktop): rescope esengine#8256 to the single compact_ratio arch…
3b3ddfb 
…itecture

Keeps the review-endorsed parts of the original four-threshold PR:
- over-threshold resume guard, asked BEFORE the mutating
  ResumeSessionPageForTab / OpenChannelSessionPageForTab calls via a
  read-only PreviewSession estimate, so cancelling leaves the session
  untouched
- immediate context + balance refresh on compaction_done

Drops everything tied to the multi-threshold model removed by esengine#8244
(soft/snip/force ratios, the four-thumb slider, thresholdLayout,
SetCompactionThresholds, CLI snip-ratio, the widened compact-ratio range)
and does not reintroduce the ContextPanel maintenance block removed by
Compact threshold on current main-v2, so the gauge needs no change.
@complyue complyue changed the title feat(desktop,agent): compaction threshold slider, real-occupancy thresholds and live context capacity pins feat(desktop): over-threshold resume guard and compaction_done live refresh Aug 11, 2026
cyue
feat(desktop): over-threshold resume guard and compaction_done live r…
417ddc0 
…efresh

Keeps the review-endorsed parts of the original four-threshold PR esengine#8256,
rescaled to the single compact_ratio architecture of esengine#8244:
- over-threshold resume guard, asked BEFORE the mutating
  ResumeSessionPageForTab / OpenChannelSessionPageForTab calls via a
  read-only PreviewSession estimate, so cancelling leaves the session
  untouched
- immediate context + balance refresh on compaction_done (the coalesced
  BalanceForTab query is invalidated first so the refresh reads fresh data)

Drops everything tied to the multi-threshold model removed by esengine#8244
(soft/snip/force ratios, the four-thumb slider, thresholdLayout,
SetCompactionThresholds, CLI snip-ratio, the widened compact-ratio range)
and does not reintroduce the ContextPanel maintenance block removed by
esengine#8265. The live capacity visualization already aligns with the single
Compact threshold on current main-v2 (esengine#8329/esengine#8307), so the gauge is
unchanged.
@complyue
complyue force-pushed the feature/compaction-thresholds-slider branch from 3b3ddfb to 417ddc0 Compare August 11, 2026 11:26
@complyue

complyue commented Aug 11, 2026

Copy link
Copy Markdown
Author

@SivanCola respect your upstream decisions, if you see single compact_ratio is the best fit, there it goes. Then this PR doesn't seem do much, DSV4F has simplified the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SivanCola SivanCola Awaiting requested review from SivanCola SivanCola is a code owner
@esengine esengine Awaiting requested review from esengine esengine is a code owner

Assignees

No one assigned

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) tui Terminal UI / CLI (internal/cli, internal/control) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@complyue @SivanCola